Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[code-infra] Remove custom TS installation script #40636

Merged
merged 2 commits into from
Jan 25, 2024

Conversation

michaldudak
Copy link
Member

Removed the custom script that installed the preview version of Typescript for tests (https://app.circleci.com/insights/github/mui/material-ui/workflows/typescript-next/overview?branch=b1d8acd4-8701-4c76-8a87-7ff2320aa95f) and replaced it with pnpm add.

@michaldudak michaldudak added the scope: code-infra Specific to the core-infra product label Jan 16, 2024
@michaldudak michaldudak requested a review from a team January 16, 2024 11:58
@michaldudak michaldudak marked this pull request as draft January 16, 2024 12:00
@mui-bot
Copy link

mui-bot commented Jan 16, 2024

Netlify deploy preview

https://deploy-preview-40636--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 0a5d1cf

package.json Outdated
"tsup": "^8.0.1",
"typescript": "^5.3.3",
"tsx": "^4.7.0",
"typescript": "5.4.0-dev.20240116",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

accidentally committed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, just to test if all CI steps pass. I'm going to revert it.

@michaldudak michaldudak marked this pull request as ready for review January 16, 2024 14:31
@michaldudak michaldudak merged commit 797e7fc into mui:master Jan 25, 2024
19 checks passed
@michaldudak michaldudak deleted the fix-typescript-next-tests branch January 25, 2024 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: code-infra Specific to the core-infra product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants