[core] Remove unneeded use-clients #40663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netlify deploy previewhttps://deploy-preview-40663--material-ui.netlify.app/ Bundle size reportDetails of bundle changes (Toolpad) |
mj12albert
approved these changes
Jan 23, 2024
|
As a side note, I pushed 9f976ac as I needed to do the same change locally to try to make |
This was referenced Apr 15, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm randomly removing a few of what I believe are harmful "use client" from our source to prove my point in #39010 (comment). It's best to apply "use client" as late as possible in the import path because this allows to export of more modules that can be in the server bundle or client bundle interchangeably.
My idea is that if this goes smoothly in production after a couple of weeks, we can go all-in.