[examples] Fix build on Next.js Pages Router examples #40665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
added
bug 🐛
Netlify deploy previewhttps://deploy-preview-40665--material-ui.netlify.app/ Bundle size report |
github-actions
bot
added
the
PR: out-of-date
oliviertassinari
force-pushed
the
fix-yarn-build-fail
branch
from
deee910
to
a221352
Compare
github-actions
bot
removed
the
PR: out-of-date
| CacheProvider?: (props: { | ||
| value: EmotionCache; | ||
| children: React.ReactNode; | ||
| }) => React.JSX.Element | null; | ||
| CacheProvider?: React.ElementType<{ value: EmotionCache }>; |
| emotionStyleTags: React.JSX.Element[]; | ||
| emotionStyleTags: React.ReactElement[]; |
There was a problem hiding this comment.
See https://stackoverflow.com/questions/58123398/when-to-use-jsx-element-vs-reactnode-vs-reactelement for why this type didn't make much sense.
siriwatknp
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the reproduction of #37500 still leads to an error (but a different kind):
This is a regression from #40199. It's a quick fix, so I thought I might as well go for it.