Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test] Speed up the envinfo test #40669

Merged
merged 4 commits into from
Jan 29, 2024

Conversation

michaldudak
Copy link
Member

@michaldudak michaldudak commented Jan 18, 2024

Speeds up the envinfo package test that often times out:

  • instead of installing packages during the test, we rely on the packages being installed for the whole workspace
  • instead of building the envinfo package and calling npx, the script is tested by executing it directly with node. This slightly increases the potential for errors, but given that the package is hardly ever updated, it's a risk we can accept.

@mui-bot
Copy link

mui-bot commented Jan 18, 2024

Netlify deploy preview

https://deploy-preview-40669--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 22ef9c4

@michaldudak michaldudak requested a review from a team January 18, 2024 10:01
@michaldudak michaldudak marked this pull request as ready for review January 18, 2024 10:02
@michaldudak michaldudak marked this pull request as draft January 18, 2024 10:22
@michaldudak michaldudak marked this pull request as ready for review January 18, 2024 20:33
@github-actions github-actions bot added PR: out-of-date The pull request has merge conflicts and can't be merged and removed PR: out-of-date The pull request has merge conflicts and can't be merged labels Jan 19, 2024
@michaldudak michaldudak requested a review from a team January 25, 2024 10:39
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Jan 28, 2024
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Jan 29, 2024
@oliviertassinari
Copy link
Member

oliviertassinari commented Jan 29, 2024

Speeds up the envinfo package test that often times out:

To understand the pain, I guess it's more to improve the CI flakiness KPI than reduce time spent?

https://app.circleci.com/pipelines/github/mui/material-ui/119808/workflows/29cf5751-7417-43ec-bb9a-e9a072fd4836/jobs/644209

@oliviertassinari oliviertassinari changed the title [envinfo] Speed up the envinfo test [test] Speed up the envinfo test Jan 29, 2024
@michaldudak
Copy link
Member Author

Both, actually. A simpler way to improve flakiness would be to increase the timeout, but given the low risk associated with this test, I ended up reimplemienting it.

@michaldudak michaldudak merged commit 93f307b into mui:master Jan 29, 2024
19 checks passed
@michaldudak michaldudak deleted the speed-up-envinfo-test branch January 29, 2024 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants