Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[website] Revamp the testimonial section in the homepage #40752

Merged
merged 7 commits into from
Jan 25, 2024

Conversation

danilo-leal
Copy link
Contributor

@danilo-leal danilo-leal commented Jan 23, 2024

This PR's changes include:

  • General uplift on this section's design to make all of them visible without having to interact with the slider
  • Add a new testimonial from Kyle Gil :)
  • Slight updates to the section right on top (not the focus of this PR, though, so not to distract that much)

https://deploy-preview-40752--material-ui.netlify.app/

@danilo-leal danilo-leal added design This is about UI or UX design, please involve a designer website Pages that are not documentation-related, marketing-focused. labels Jan 23, 2024
@danilo-leal danilo-leal self-assigned this Jan 23, 2024
@mui-bot
Copy link

mui-bot commented Jan 23, 2024

Netlify deploy preview

https://deploy-preview-40752--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against f00cf6d

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Jan 23, 2024
@danilo-leal danilo-leal requested review from a team and removed request for siriwatknp January 23, 2024 22:49
Signed-off-by: Danilo Leal <67129314+danilo-leal@users.noreply.github.com>
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Jan 23, 2024
Copy link
Contributor

@zanivan zanivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks great! I like how we can see all the testimonials at once now 🚀

@danilo-leal danilo-leal merged commit c192fba into mui:master Jan 25, 2024
19 checks passed
@danilo-leal danilo-leal deleted the revamp-homepage-testiomonials branch January 25, 2024 12:29
Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

borderRadius: 1,
overflow: 'clip',
'> :nth-of-type(1)': { borderBottom: `1px solid ${theme.palette.primaryDark[700]}` },
'> :nth-of-type(2)': {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From a syntax perspective, I would be more in favor to always be explicit. A bit similar to the native CSS feature https://developer.mozilla.org/en-US/docs/Web/CSS/Nesting_selector (not directly related API though)

Suggested change
'> :nth-of-type(2)': {
'& > :nth-of-type(2)': {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design This is about UI or UX design, please involve a designer website Pages that are not documentation-related, marketing-focused.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants