Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[joy-ui] Change the color scheme type to SupportedColorScheme #40776

Merged
merged 1 commit into from
Jan 26, 2024

Conversation

Nikhilh26
Copy link
Contributor

@Nikhilh26 Nikhilh26 commented Jan 24, 2024

Closes #40664

@mui-bot
Copy link

mui-bot commented Jan 24, 2024

Netlify deploy preview

https://deploy-preview-40776--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 57e4564

@Nikhilh26
Copy link
Contributor Author

I dont understand why its failing

@danilo-leal danilo-leal changed the title Made changes as highlighted [joy-ui] Change the color scheme type to SupportedColorScheme Jan 24, 2024
@danilo-leal danilo-leal added package: joy-ui Specific to @mui/joy customization: theme Centered around the theming features labels Jan 24, 2024
@danilo-leal
Copy link
Contributor

Heya @Nikhilh26, thanks for opening your first issue here (and for your interest in Joy UI!). I'll leave @siriwatknp do the actual code review, but just wanted to pass along and drop a couple of tips about PR formating given you mentioned the tests failing:

  • Always write the title in imperative form — i.e., "Add", "Change", "Make", etc.
  • Add the product you're affecting in brackets — [joy-ui], [material-ui], etc.
  • If you're opening a PR in light of an issue, use key words such as "Closes" and "Fixes" before the issue URL. GitHub then links them automatically, and once the PR is merged, the issue will be also closed.
  • Make sure you add labels before opening the PR — that's why the tests were failing.

@Nikhilh26
Copy link
Contributor Author

What are labels 😅

@danilo-leal
Copy link
Contributor

You can add them either before or after opening PRs 👍

Screenshot 2024-01-24 at 13 49 27

@Nikhilh26
Copy link
Contributor Author

Thank you so much!

@sai6855
Copy link
Contributor

sai6855 commented Jan 24, 2024

Make sure you add labels before opening the PR — that's why the tests were failing.
@danilo-leal i don't think contributors can add/remove labels, it's only restricted to maintainers

@siriwatknp siriwatknp merged commit 3f2a063 into mui:master Jan 26, 2024
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
customization: theme Centered around the theming features package: joy-ui Specific to @mui/joy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[joy-ui] useColorScheme uses DefaultColorScheme instead of SupportedColorScheme
5 participants