[Dialog] Do not mix padding and padding top #4082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -12,7 +12,7 @@ | |||
| "private": true, | |||
| "scripts": { | |||
| "start": "npm run browser:development", | |||
| "browser:development": "webpack-dev-server --config webpack-dev-server.config.js --progress --colors --inline --host=", | |||
| "browser:development": "webpack-dev-server --config webpack-dev-server.config.js --progress --colors --inline", | |||
There was a problem hiding this comment.
Did you figure out your problem with this? I remember merging the --host= argument as it didn't break anything for me.
There was a problem hiding this comment.
When using --host= I have a warning in the console saying the hot reloading end point can't be reached.
I haven't investigated. I just though it would be safer to revert.
There was a problem hiding this comment.
I find the hot reloading pretty iffy on our docs anyways -- I haven't been depending on it 😟
zannager
added
the
component: dialog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DatePickerDialogis resetting the padding withpadding: 0. But that has no impact on thepaddingTopproperty.