Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] missingKeyGenerator do no longer exist #40830

Merged
merged 2 commits into from
Jan 30, 2024
Merged

[core] missingKeyGenerator do no longer exist #40830

merged 2 commits into from
Jan 30, 2024

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Jan 28, 2024 •
edited

missingKeyGenerator was removed in #37364 but the comment were not updated.

@oliviertassinari oliviertassinari added core Infrastructure work going on behind the scenes package: base-ui Specific to @mui/base labels Jan 28, 2024
@mui-bot
Copy link

mui-bot commented Jan 28, 2024 •
edited

Netlify deploy preview

https://deploy-preview-40830--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 5f24fe8

@oliviertassinari @mnajdova
typo
5f24fe8 
Co-authored-by: Marija Najdova <mnajdova@gmail.com>
Signed-off-by: Olivier Tassinari <olivier.tassinari@gmail.com>
@oliviertassinari oliviertassinari changed the title [core] missingKeyGenerator do no longer exist [core] missingKeyGenerator do no longer exist Jan 29, 2024
michaldudak
michaldudak approved these changes Jan 29, 2024
View reviewed changes
Copy link
Member

@michaldudak michaldudak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@oliviertassinari oliviertassinari merged commit b842f94 into mui:master Jan 30, 2024
19 checks passed
@oliviertassinari oliviertassinari deleted the missingKeyGenerator-refactor branch January 30, 2024 00:45
mostafa-rio pushed a commit to mostafa-rio/material-ui that referenced this pull request Feb 3, 2024
@oliviertassinari @mnajdova @mostafa-rio
[core] missingKeyGenerator do no longer exist (mui#40830)
08321b1 
Signed-off-by: Olivier Tassinari <olivier.tassinari@gmail.com>
Co-authored-by: Marija Najdova <mnajdova@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnajdova mnajdova mnajdova left review comments

@michaldudak michaldudak michaldudak approved these changes

Assignees
No one assigned
Labels
core Infrastructure work going on behind the scenes package: base-ui Specific to @mui/base
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@oliviertassinari @mui-bot @mnajdova @michaldudak