Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[blog] Lint duplicate h1 on the page #40835

Merged
merged 1 commit into from
Jan 29, 2024

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Jan 28, 2024

This new lint fails the ci when it sees a h1 or duplicated h1 in a page where h1 isn't the first element #40784 (comment).

For example:

diff --git a/docs/data/material/components/alert/alert.md b/docs/data/material/components/alert/alert.md
index 1f1a903f2c..bcde949fe0 100644
--- a/docs/data/material/components/alert/alert.md
+++ b/docs/data/material/components/alert/alert.md
@@ -6,13 +6,15 @@ githubLabel: 'component: alert'
 waiAria: https://www.w3.org/WAI/ARIA/apg/patterns/alert/
 ---

+a
+
 # Alert

 <p class="description">Alerts display brief messages for the user without interrupting their use of the app.</p>

 {{"component": "modules/components/ComponentLinkHeader.js"}}

-## Introduction
+# Introduction

 Alerts give users brief and potentially time-sensitive information in an unobtrusive manner.

diff --git a/docs/pages/blog/2022-tenerife-retreat.md b/docs/pages/blog/2022-tenerife-retreat.md
index 0d0827075e..694c7fea6f 100644
--- a/docs/pages/blog/2022-tenerife-retreat.md
+++ b/docs/pages/blog/2022-tenerife-retreat.md
@@ -7,6 +7,8 @@ tags: ['Company']
 card: true
 ---

+# A
+
 One of the toughest challenges to overcome as a fully remote team is fostering a supportive and inclusive company culture.
 How do you build trust, comradery, and—dare I say it?—_friendships_, when there are so few opportunities for spontaneous social interactions in our daily work routines?

@oliviertassinari oliviertassinari added bug 🐛 Something doesn't work core Infrastructure work going on behind the scenes blog labels Jan 28, 2024
@mui-bot
Copy link

mui-bot commented Jan 28, 2024

Netlify deploy preview

https://deploy-preview-40835--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against a60f074

Copy link
Contributor

@noraleonte noraleonte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@oliviertassinari oliviertassinari merged commit 2b751cf into mui:master Jan 29, 2024
19 checks passed
@oliviertassinari oliviertassinari deleted the blog-lint-h1 branch January 29, 2024 14:05
mostafa-rio pushed a commit to mostafa-rio/material-ui that referenced this pull request Feb 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blog bug 🐛 Something doesn't work core Infrastructure work going on behind the scenes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants