Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[material-ui][system] Use direct import #40851

Merged
merged 25 commits into from Feb 15, 2024

Conversation

siriwatknp
Copy link
Member

@siriwatknp siriwatknp commented Jan 30, 2024

Motivation

  • To support importing modules as React server component
  • Ensure that only required modules are processed by zero-runtime

The changes are tested by MUI Blog migration to zero-runtime https://mui-blog-benchmark-kb0umgi4g-siriwatknp.vercel.app/blog


@siriwatknp siriwatknp added the package: codemod Specific to @mui/codemod label Jan 30, 2024
@mui-bot
Copy link

mui-bot commented Jan 30, 2024

Netlify deploy preview

https://deploy-preview-40851--material-ui.netlify.app/

@material-ui/core: parsed: +3.64% , gzip: +2.85%
@material-ui/lab: parsed: +4.48% , gzip: +3.66%
@mui/material-next: parsed: +4.57% , gzip: +2.98%

Bundle size report

Details of bundle changes (Toolpad)
Details of bundle changes

Generated by 🚫 dangerJS against 58f8b93

@siriwatknp siriwatknp marked this pull request as ready for review February 12, 2024 08:16
@siriwatknp siriwatknp changed the title [codemod] Add direct import transformation [material-ui][system] Use direct import Feb 12, 2024
@siriwatknp siriwatknp requested review from brijeshb42, mnajdova and a team February 12, 2024 08:18
Copy link
Member

@michaldudak michaldudak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 At some point (when this excercise is done in all projects), we can remove the main index file from the utils to disallow importing from the root at all.

@siriwatknp siriwatknp merged commit ef23952 into mui:master Feb 15, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: codemod Specific to @mui/codemod
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants