Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[base-ui][docs] Improve Base UI traffic from Material UI #40875

Merged
merged 6 commits into from
Feb 3, 2024

Conversation

@oliviertassinari oliviertassinari added the docs Improvements or additions to the documentation label Jan 31, 2024
@mui-bot
Copy link

mui-bot commented Jan 31, 2024

Netlify deploy preview

https://deploy-preview-40875--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 8c24b60

@samuelsycamore
Copy link
Member

samuelsycamore commented Jan 31, 2024

Thinking about this section in the context of the Material UI Button page, I'm afraid we're going to confuse users with the (Material UI) Button Base component and the Base UI Button component. Maybe we should add more (could just be another sentence or two) to this section to help users understand why they'd pick the Base UI component?

Copy link
Member Author

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then maybe something like this

packages/markdown/prepareMarkdown.js Outdated Show resolved Hide resolved
packages/markdown/prepareMarkdown.js Outdated Show resolved Hide resolved
oliviertassinari and others added 2 commits February 1, 2024 01:36
Co-authored-by: Danilo Leal <67129314+danilo-leal@users.noreply.github.com>
Signed-off-by: Olivier Tassinari <olivier.tassinari@gmail.com>
@oliviertassinari oliviertassinari added the package: base-ui Specific to @mui/base label Feb 3, 2024
Copy link
Contributor

@danilo-leal danilo-leal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me! 🤙

@oliviertassinari oliviertassinari enabled auto-merge (squash) February 3, 2024 16:55
@oliviertassinari oliviertassinari merged commit 958891b into mui:master Feb 3, 2024
19 checks passed
@oliviertassinari oliviertassinari deleted the base-ui-link branch February 3, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation package: base-ui Specific to @mui/base
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants