Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[zero] Always replace the createUseThemeProps call #40885

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

siriwatknp
Copy link
Member

Issue

If there are no default props provided, the Badge still uses useThemeProps from the system.

The build result:

import { createUseThemeProps } from "../zero-styled";

const useThemeProps = createUseThemeProps("MuiBadge");

After

Always replace the call with zero-runtime tag if the import is used.

The build result:

import { createUseThemeProps as _createUseThemeProps } from "@mui/zero-runtime";

const useThemeProps = /*#__PURE__*/_createUseThemeProps("MuiBadge");

@siriwatknp siriwatknp added bug 🐛 Something doesn't work package: pigment-css Specific to @pigment-css/* labels Feb 1, 2024
@mui-bot
Copy link

mui-bot commented Feb 1, 2024

Netlify deploy preview

https://deploy-preview-40885--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 11d4ad9

@siriwatknp siriwatknp merged commit f71f514 into mui:master Feb 1, 2024
21 checks passed
mostafa-rio pushed a commit to mostafa-rio/material-ui that referenced this pull request Feb 3, 2024
@oliviertassinari oliviertassinari added the package: system Specific to @mui/system label Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work package: pigment-css Specific to @pigment-css/* package: system Specific to @mui/system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants