[material-ui][docs] Migrating from deprecated apis follow up #40981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DiegoAndai
added
docs
Netlify deploy previewBundle size report |
oliviertassinari
approved these changes
Feb 7, 2024
| @@ -30,22 +30,22 @@ If you need to run a specific codemod, those are also linked below. | |||
|
|
|||
| ### TransitionComponent | |||
|
|
|||
| The Accordion's `TransitionComponent` was deprecated in favor of `slots.transition` ([Codemod](https://github.com/mui/material-ui/tree/master/packages/mui-codemod#accordion-props)): | |||
| The Accordion's `TransitionComponent` was deprecated in favor of `slots.transition` ([Codemod](https://github.com/mui/material-ui/tree/HEAD/packages/mui-codemod#accordion-props)): | |||
There was a problem hiding this comment.
The only potential opportunity I could spot:
Suggested change
| The Accordion's `TransitionComponent` was deprecated in favor of `slots.transition` ([Codemod](https://github.com/mui/material-ui/tree/HEAD/packages/mui-codemod#accordion-props)): | |
| The Accordion's `TransitionComponent` was deprecated in favor of `slots.transition` ([Codemod](https://github.com/mui/material-ui/tree/HEAD/packages/mui-codemod#accordion-props)). | |
| We are making this change to normalize the customization of nested elements with a single `slots` prop across all components: |
There was a problem hiding this comment.
I agree. I'll add a single explanation for the overarching slot pattern standardization on top of the guide and link it to each deprecation. I want to release a brief blog about it alongside it so we can share it. I'll handle this one separately this week. (Also replied here #40767 (comment))
This was referenced May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up from #40767 (review)
Preview: https://deploy-preview-40981--material-ui.netlify.app/material-ui/migration/migrating-from-deprecated-apis/