Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[material-ui][Tooltip] Remove incorrect code comment #41179

Merged

Conversation

ZeeshanTamboli
Copy link
Member

@ZeeshanTamboli ZeeshanTamboli commented Feb 19, 2024

Small change. Found this incorrect code comment while investigating a tooltip issue. It appears that the comment was mistakenly relocated to the pointerEvents property in pull request #20745 in v4, which involved removing the flip property of the jss-rtl plugin.

@ZeeshanTamboli ZeeshanTamboli added component: tooltip This is the name of the generic UI component, not the React module! package: material-ui Specific to @mui/material labels Feb 19, 2024
@ZeeshanTamboli ZeeshanTamboli marked this pull request as ready for review February 19, 2024 13:06
@mui-bot
Copy link

mui-bot commented Feb 19, 2024

Netlify deploy preview

https://deploy-preview-41179--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 3809d85

Copy link
Member

@DiegoAndai DiegoAndai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@siriwatknp siriwatknp merged commit 910cc46 into mui:master Feb 20, 2024
21 checks passed
@ZeeshanTamboli ZeeshanTamboli deleted the remove-incorrect-code-comment-tooltip branch February 20, 2024 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: tooltip This is the name of the generic UI component, not the React module! package: material-ui Specific to @mui/material
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants