[material] Remove unused dev dependency on @mui/lab #41198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
brijeshb42
commented
Feb 20, 2024
brijeshb42
commented
- I have followed (at least) the PR section of the contributing guide.
brijeshb42
requested review from
Janpot and
a team
and removed request for
Janpot
Netlify deploy previewhttps://deploy-preview-41198--material-ui.netlify.app/ Bundle size report |
|
This looked like a circular dependency 😁 |
|
For some reason there is a test in @mui/material that imports from @mui/lab: packages/mui-material/test/typescript/color-palette-prop.spec.tsx. I think the part of this test that references TimelineDot can be moved to the Lab.
Yeah, it wasn't reported by pnpm, though, as @mui/material is a peer dependency. |
github-actions
bot
added
the
PR: out-of-date
brijeshb42
force-pushed
the
material-cicular-import
branch
from
2b18267
to
5cef954
Compare
github-actions
bot
removed
the
PR: out-of-date
michaldudak
reviewed
Feb 23, 2024
brijeshb42
force-pushed
the
material-cicular-import
branch
from
5cef954
to
bafa5c3
Compare
|
It was always reported when I tried to run some command directly through |
Janpot
approved these changes
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.