Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[code-infra] Prepare the markdown package for publishing #41240

Merged
merged 12 commits into from Feb 26, 2024

Conversation

michaldudak
Copy link
Member

@michaldudak michaldudak commented Feb 22, 2024

Renamed the @mui/markdown to @mui/internal-markdown and prepared it for publishing.
I had to modify the package itself to make it independent from the location it's stored.
Most of the changed files are related to the rename (they are all in a single commit, so they can be skipped during review).
The changes in docs files are not strictly necessary (as the imported path query string is also configurable in webpack settings), but I opted for consistency.

X integration: mui/mui-x#12188
Toolpad integration: mui/mui-toolpad#3235

@michaldudak michaldudak added the scope: code-infra Specific to the core-infra product label Feb 22, 2024
@mui-bot
Copy link

mui-bot commented Feb 22, 2024

Netlify deploy preview

https://deploy-preview-41240--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against f4b0e52

@michaldudak michaldudak requested a review from a team February 23, 2024 07:32
@michaldudak michaldudak marked this pull request as ready for review February 23, 2024 07:37
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Feb 23, 2024
Copy link
Member

@Janpot Janpot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Feb 26, 2024
@michaldudak michaldudak merged commit 5e4e18a into mui:master Feb 26, 2024
22 checks passed
@michaldudak michaldudak deleted the npm-publishing/markdown branch February 26, 2024 13:34
mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: code-infra Specific to the core-infra product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants