Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[website] Use MUI X Data Grid v7-beta #41276

Merged
merged 14 commits into from Mar 13, 2024
Merged

[website] Use MUI X Data Grid v7-beta #41276

merged 14 commits into from Mar 13, 2024

Conversation

cherniavskii
Copy link
Member

@cherniavskii cherniavskii commented Feb 26, 2024 •
edited by danilo-leal

@cherniavskii cherniavskii added website Pages that are not documentation-related, marketing-focused. MUI X labels Feb 26, 2024
@netlify Netlify
Copy link

netlify bot commented Feb 26, 2024 •
edited

✅ Deploy Preview for resonant-twilight-4b0c91 canceled.

Name Link
🔨 Latest commit 7fa3f4b
🔍 Latest deploy log https://app.netlify.com/sites/resonant-twilight-4b0c91/deploys/65dcac474d2d620008a2ef55

@mui-bot
Copy link

mui-bot commented Feb 26, 2024 •
edited

Netlify deploy preview

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against ef414e9

@oliviertassinari oliviertassinari added the component: data grid This is the name of the generic UI component, not the React module! label Feb 26, 2024
@oliviertassinari oliviertassinari changed the title [website] Use DataGrid v7 beta [website] Use MUI X Data Grid v7-beta Feb 26, 2024
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Mar 2, 2024
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Mar 12, 2024
@cherniavskii cherniavskii marked this pull request as ready for review March 12, 2024 19:44
danilo-leal
danilo-leal approved these changes Mar 13, 2024
View reviewed changes
Copy link
Contributor

@danilo-leal danilo-leal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Digging the CSS variables usage 😃 Left just a minor suggestion on the Table callout, but approving it tentatively. Would wait for Sam's double check on it, though.

docs/data/material/components/table/table.md Outdated Show resolved Hide resolved
@cherniavskii @danilo-leal
Update docs/data/material/components/table/table.md
ef414e9 
Co-authored-by: Danilo Leal <67129314+danilo-leal@users.noreply.github.com>
Signed-off-by: Andrew Cherniavskii <andrew.cherniavskii@gmail.com>
@cherniavskii cherniavskii enabled auto-merge (squash) March 13, 2024 14:58
@cherniavskii cherniavskii merged commit e6a51d3 into mui:master Mar 13, 2024
22 checks passed
@cherniavskii cherniavskii deleted the upgrade-data-grid branch March 13, 2024 15:23
@cherniavskii cherniavskii restored the upgrade-data-grid branch March 13, 2024 15:23
@cherniavskii cherniavskii deleted the upgrade-data-grid branch March 13, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danilo-leal danilo-leal danilo-leal approved these changes

@joserodolfofreitas joserodolfofreitas Awaiting requested review from joserodolfofreitas

Assignees
No one assigned
Labels
component: data grid This is the name of the generic UI component, not the React module! MUI X website Pages that are not documentation-related, marketing-focused.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@cherniavskii @mui-bot @danilo-leal @oliviertassinari