Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[website] Polish Button outline primary medium #41298

Merged
merged 1 commit into from Feb 27, 2024

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Feb 27, 2024

This feels better:

Screen.Recording.2024-02-27.at.23.21.30.mov

@oliviertassinari oliviertassinari added design This is about UI or UX design, please involve a designer website Pages that are not documentation-related, marketing-focused. labels Feb 27, 2024
@mui-bot
Copy link

mui-bot commented Feb 27, 2024

Netlify deploy preview

https://deploy-preview-41298--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 36a4e8a

Copy link
Contributor

@danilo-leal danilo-leal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me — transition working much better 👌

@@ -508,7 +508,7 @@ export function getThemedComponents(): ThemeOptions {
0.8,
)} 0 -2px 0 inset, ${alpha(theme.palette.grey[200], 0.5)} 0 1px 2px 0`,
'&:hover': {
background: (theme.vars || theme).palette.primaryDark[50],
backgroundColor: (theme.vars || theme).palette.primaryDark[50],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ha, backgroundColor is the correct one then for the transitions 👍

@oliviertassinari oliviertassinari merged commit 1250208 into mui:master Feb 27, 2024
21 checks passed
@oliviertassinari oliviertassinari deleted the fix-button-padding-y branch February 27, 2024 23:13
mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design This is about UI or UX design, please involve a designer website Pages that are not documentation-related, marketing-focused.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants