[code-infra] Use Circle CI context #41532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
added
core
oliviertassinari
force-pushed
the
circle-ci-use-context
branch
2 times, most recently
from
b8e9ad0
to
9d9b038
Compare
Netlify deploy previewhttps://deploy-preview-41532--material-ui.netlify.app/ Bundle size report |
oliviertassinari
force-pushed
the
circle-ci-use-context
branch
from
9d9b038
to
b19fdc9
Compare
|
It works: 
|
oliviertassinari
force-pushed
the
circle-ci-use-context
branch
from
b19fdc9
to
79c678c
Compare
oliviertassinari
force-pushed
the
circle-ci-use-context
branch
from
79c678c
to
6c2e463
Compare
oliviertassinari
added a commit
to mui/base-ui
that referenced
this pull request
Mar 17, 2024
oliviertassinari
added a commit
to mui/mui-x
that referenced
this pull request
Mar 17, 2024
oliviertassinari
added a commit
to mui/mui-toolpad
that referenced
this pull request
Mar 17, 2024
oliviertassinari
added a commit
to mui/mui-public
that referenced
this pull request
Mar 17, 2024
oliviertassinari
changed the title
cherniavskii
pushed a commit
to cherniavskii/mui-x
that referenced
this pull request
Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR means that we don't have to duplicate the same tokens in each GitHub repository configuration. Simpler for the code-infra to work on the codebase by defining them once (e.g. token rotation). So far, we have 3 variables shared between the repositories.
https://app.circleci.com/settings/organization/github/mui/contexts/3f0e38e1-5317-4a70-9505-f9b8ccc9fee2?return-to=https%3A%2F%2Fapp.circleci.com%2Fpipelines%2Fgithub%2Fmui
Note that all open PRs need to be rebased on HEAD to work. I removed the tokens of each Circle CI repository that duplicate with the Circle CI organization.
This is part of the larger effort to break down Material UI into projects of smaller scopes, so they have a stronger chance to be entry points for developers, but also so we have more focus.