Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[system] Fix typo to avoid infinite recursion in function call. #41616

Merged
merged 1 commit into from Mar 25, 2024

Conversation

michael-land
Copy link
Contributor

@michael-land michael-land commented Mar 24, 2024

closes #41615

the previous version cause infinite recursion

export function private_safeEmphasize(color, coefficient, warning) {
  try {
    //    return private_safeEmphasize(color, coefficient);
    return emphasize(color, coefficient);
  } catch (error) {
    if (warning && process.env.NODE_ENV !== 'production') {
      console.warn(warning);
    }
    return color;
  }
}

Signed-off-by: Michael Li <33362998+michael-land@users.noreply.github.com>
@mui-bot
Copy link

mui-bot commented Mar 24, 2024

Netlify deploy preview

https://deploy-preview-41616--material-ui.netlify.app/

Bundle size report

Details of bundle changes (Toolpad)
Details of bundle changes

Generated by 🚫 dangerJS against deecbf8

Copy link
Member

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks a lot for the fix!

@siriwatknp siriwatknp added bug 🐛 Something doesn't work package: system Specific to @mui/system labels Mar 25, 2024
@siriwatknp siriwatknp changed the title fix: fix typo to avoid infinite recursion in function call. [system] Fix typo to avoid infinite recursion in function call. Mar 25, 2024
@siriwatknp siriwatknp merged commit 4be02a5 into mui:next Mar 25, 2024
20 of 21 checks passed
ZeeshanTamboli pushed a commit to ZeeshanTamboli/material-ui that referenced this pull request Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work package: system Specific to @mui/system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Snackbar background color is not as expected with CssVarProvider
3 participants