Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dedupe check #41657

Merged
merged 3 commits into from Mar 26, 2024
Merged

Fix dedupe check #41657

merged 3 commits into from Mar 26, 2024

Conversation

Janpot
Copy link
Member

@Janpot Janpot commented Mar 26, 2024 •
edited

  • compare against the next branch
  • include package.json
  • fix lock file name

Note: the check is passing in this CI run because we're not editing any of these files. But it's currently broken on CI. Will fix in a separate PR

@mui-bot
Copy link

mui-bot commented Mar 26, 2024 •
edited

Netlify deploy preview

https://deploy-preview-41657--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against afc25d0

@Janpot Janpot marked this pull request as ready for review March 26, 2024 09:20
@Janpot Janpot requested a review from a team March 26, 2024 09:20
michaldudak
michaldudak approved these changes Mar 26, 2024
View reviewed changes
Copy link
Member

@michaldudak michaldudak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok

@Janpot Janpot enabled auto-merge (squash) March 26, 2024 09:24
@Janpot Janpot mentioned this pull request Mar 26, 2024
Merged
brijeshb42
brijeshb42 approved these changes Mar 26, 2024
View reviewed changes
Copy link
Contributor

@brijeshb42 brijeshb42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix.

@mnajdova mnajdova merged commit 9dd63c4 into mui:next Mar 26, 2024
19 checks passed
@michaldudak michaldudak mentioned this pull request Mar 26, 2024
Merged
tejasparkar pushed a commit to tejasparkar/material-ui that referenced this pull request Mar 30, 2024
@Janpot @tejasparkar
Fix dedupe check (mui#41657)
26d5b11
@zannager zannager added the docs Improvements or additions to the documentation label Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brijeshb42 brijeshb42 brijeshb42 approved these changes

@michaldudak michaldudak michaldudak approved these changes

Assignees
No one assigned
Labels
docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Janpot @mui-bot @brijeshb42 @michaldudak @mnajdova @zannager