[material-ui][Select] Fix muiName property TypeScript error
#41726
+12
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netlify deploy previewhttps://deploy-preview-41726--material-ui.netlify.app/ Bundle size report |
danilo-leal
changed the title
muiName property TypeScript error
danilo-leal
reviewed
Apr 1, 2024
danilo-leal
added
component: select
EyaOuenniche
force-pushed
the
add-muiname-to-select-component
branch
from
c262f17
to
d4da7e3
Compare
…nclude the muiName static property
EyaOuenniche
force-pushed
the
add-muiname-to-select-component
branch
from
d4da7e3
to
a0d7a86
Compare
…ges in PropTypes following the previous Select definition change
| @@ -151,23 +151,26 @@ export interface BaseSelectProps<Value = unknown> | |||
| variant?: SelectVariants; | |||
| } | |||
|
|
|||
| export interface FilledSelectProps extends Omit<FilledInputProps, 'value' | 'onChange'> { | |||
| export interface FilledSelectProps | |||
| extends Omit<FilledInputProps, 'value' | 'onChange' | 'id' | 'classes' | 'inputProps'> { | |||
There was a problem hiding this comment.
We need to omit these props in the types because the pnpm proptypes started to fail after the change in the Select definition below. I believe this adjustment is now correct. Previously, it may not have been picking up the props correctly, possibly due to an incorrect intersection with muiName: string.
ZeeshanTamboli
approved these changes
Apr 6, 2024
There was a problem hiding this comment.
@EyaOuenniche I made the expected changes. Thanks for the pull request.
ZeeshanTamboli
added
the
needs cherry-pick
github-actions bot
pushed a commit
that referenced
this pull request
Apr 6, 2024
Co-authored-by: ZeeshanTamboli <zeeshan.tamboli@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request addresses a TypeScript error when assigning muiName to a custom component based on Material-UI's Select. It ensures the muiName property is properly recognized in the type definition, facilitating successful compilation.
Fixes #41707