Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[material-ui] Refine Dashboard template #41757

Open
wants to merge 83 commits into
base: next
Choose a base branch
from

Conversation

zanivan
Copy link
Contributor

@zanivan zanivan commented Apr 3, 2024

Part of #37555

This PR is for refining the Dashboard template, showcasing X's components.

Current New
image image

The thumbnails and other information will be updated after the design is done

👉 https://deploy-preview-41757--material-ui.netlify.app/material-ui/getting-started/templates/dashboard/

@zanivan zanivan added docs Improvements or additions to the documentation package: material-ui Specific to @mui/material design This is about UI or UX design, please involve a designer labels Apr 3, 2024
@mui-bot
Copy link

mui-bot commented Apr 3, 2024

Netlify deploy preview

https://deploy-preview-41757--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 77431ac

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Apr 15, 2024
@zanivan
Copy link
Contributor Author

zanivan commented May 7, 2024

Screen.Recording.2024-05-07.at.17.42.54.mov

@noraleonte what's the best approach to customize these buttons? Ideally, they could be a text variant, with a gap between buttons and a margin to the title aside. Also, is there a way to standardize them?

I wonder about the a11y of this, with invisible buttons and the huge amount of layout shifts 🤔 What could we do about it?

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label May 9, 2024
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label May 9, 2024
@zanivan
Copy link
Contributor Author

zanivan commented May 9, 2024

@noraleonte, I've switched the icons to the rounded version and I think we're ready for the first round of reviews 🙌


Just one note, though: the Page Views label is broken in light mode and I can't figure out why 😬

Screenshot 2024-05-09 at 16 29 56 Screenshot 2024-05-09 at 16 30 09

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label May 12, 2024
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design This is about UI or UX design, please involve a designer docs Improvements or additions to the documentation package: material-ui Specific to @mui/material
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants