Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs-infra] Add demo container design refinements #41948

Merged
merged 3 commits into from Apr 18, 2024

Conversation

danilo-leal
Copy link
Contributor

@danilo-leal danilo-leal commented Apr 17, 2024

Little tweaks to fine-tune the demo container even more. The primary change here is making the JS/TS toggle button look more like a pill rather than separate-looking buttons so there's no confusion with the code tabs that have been recently introduced.

https://deploy-preview-41948--material-ui.netlify.app/experiments/docs/demos/

@danilo-leal danilo-leal added design This is about UI or UX design, please involve a designer scope: docs-infra Specific to the docs-infra product labels Apr 17, 2024
@danilo-leal danilo-leal self-assigned this Apr 17, 2024
@mui-bot
Copy link

mui-bot commented Apr 17, 2024

Netlify deploy preview

https://deploy-preview-41948--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against ed5a534

Copy link
Contributor

@zanivan zanivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🔥

@zanivan
Copy link
Contributor

zanivan commented Apr 17, 2024

Just one small remark about the focus, though. It feels weird to be behind the button—and it only happens on the JS button 🤔
Screenshot 2024-04-17 at 17 22 52

@danilo-leal
Copy link
Contributor Author

Seems like a weird toggle button + button base-defined focus-styled related problem 🤔 Good catch, but I might treat it later so I can ship this one fast. 😬

@danilo-leal danilo-leal merged commit 84adfb8 into mui:next Apr 18, 2024
19 checks passed
@danilo-leal danilo-leal deleted the demo-container-design-refinements branch April 18, 2024 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design This is about UI or UX design, please involve a designer scope: docs-infra Specific to the docs-infra product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants