Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test] Update browser versions in karma config #42008

Conversation

ZeeshanTamboli
Copy link
Member

@ZeeshanTamboli ZeeshanTamboli commented Apr 23, 2024

Similar to mui/base-ui#179.

Since we've updated the list of supported browsers, we should also update the browser versions in the karma config for browser tests.

browserstack-force run : https://app.circleci.com/pipelines/github/mui/material-ui/127738/workflows/6dbb14d6-7afa-4d20-b0e5-f0cae483bcde/jobs/688724.

Also, resolved the userEvent.setup() TODO in the Autocomplete test since we now support the new Safari version. I considered refactoring other userEvent.setup() TODOs, but they all reside in Base UI, which is planned for removal in the near future.

@mui-bot
Copy link

mui-bot commented Apr 23, 2024

Netlify deploy preview

https://deploy-preview-42008--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 632af7b

Copy link
Member

@Janpot Janpot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, looks good 👍

@ZeeshanTamboli ZeeshanTamboli merged commit 6365c52 into mui:next Apr 23, 2024
20 checks passed
@ZeeshanTamboli ZeeshanTamboli deleted the test/update-karma-config-browser-support branch April 23, 2024 16:23
mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants