[material-ui][types] Make OverridableComponent component prop optional
#42097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netlify deploy previewhttps://deploy-preview-42097--material-ui.netlify.app/ Bundle size report |
|
Based on the generation changes, it seems like there might have been a reason the prop is required? |
There was a problem hiding this comment.
@sydneyjodon-wk Could you first create a new issue where the component prop is coming through as required?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
I'm not sure if there's a reason that the
componentprop inOverridableComponentis set to required, but it's coming through as required for us for a lot of components. I'm wondering if it would be okay to make it optional here instead?Thank you!