Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[website] Avoid duplicate simple vs. rich #42100

Merged

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented May 2, 2024

I'm confused by:

SCR-20240502-tapg
  1. Simple tree view and Rich tree view are the same components (not in the React sense but UI sense), so do we need to show them twice? It makes me think that there are two, which is not the case.
  2. It feels like the page promise that all tree view features are open-source, but we have https://github.com/mui/mui-x/issues?q=is%3Aopen+is%3Aissue+label%3A%22component%3A+tree+view%22+sort%3Areactions-%2B1-desc+label%3A%22plan%3A+Pro%22.

So I'm going after 1 in this PR.
For point 2. I think #41595 (comment) makes sense, but I kept this PR more focused.

After: https://deploy-preview-42100--material-ui.netlify.app/pricing/

@oliviertassinari oliviertassinari added the website Pages that are not documentation-related, marketing-focused. label May 2, 2024
@mui-bot
Copy link

mui-bot commented May 2, 2024

Netlify deploy preview

https://deploy-preview-42100--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 236fcf9

Copy link
Member

@flaviendelangle flaviendelangle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll do a follow up to introduce Tree View features like on the grid

@oliviertassinari oliviertassinari merged commit 7912ba4 into mui:next May 20, 2024
19 checks passed
@oliviertassinari oliviertassinari deleted the pricing-simplify-tree-view branch May 20, 2024 13:31
@flaviendelangle
Copy link
Member

@oliviertassinari The only problem now is that I must choose between linking to the Rich Tree View or the Simple Tree View doc when I list the features

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
website Pages that are not documentation-related, marketing-focused.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants