Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Remove unused images #42324

Merged
merged 5 commits into from
May 28, 2024
Merged

Conversation

danilo-leal
Copy link
Contributor

A bit of a clean-up as I was browsing through the image directory — all of these don't seem to be used anymore (haven't found instances of use, at least!).

@danilo-leal danilo-leal added the docs Improvements or additions to the documentation label May 21, 2024
@danilo-leal danilo-leal self-assigned this May 21, 2024
@mui-bot
Copy link

mui-bot commented May 22, 2024

Netlify deploy preview

https://deploy-preview-42324--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 3924998

@aarongarciah aarongarciah requested review from aarongarciah and removed request for mnajdova and DiegoAndai May 28, 2024 07:34
Copy link
Member

@mnajdova mnajdova May 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where are these two premium themes being linked to? We have the code for them and they are available, e.g. https://mui.com/premium-themes/onepirate/. I would assume the image would be a link card linking to these, have we removed them by any chance?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe, I don't recall any cards on the docs linking to them, and it might be what Aaron said (we're using the URL somewhere else but not in the docs). I can quickly look it uo at the Store to see if there's something there.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This template is live in the Store, but I'm not sure the image is coming from here... It doesn't seem like it is, as it looks like its being added directly to the WordPress console. https://mui.com/store/items/onepirate/

Copy link
Member

@aarongarciah aarongarciah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code-wise, all of these images seem to not be used. I wonder if we reference some of them from other projects/websites? I guess the answer is no, but just in case.

@danilo-leal danilo-leal merged commit 384e5e4 into mui:next May 28, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants