Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Remove WyW-in-JS from Renovate config #42335

Merged

Conversation

ZeeshanTamboli
Copy link
Member

It is used by Pigment CSS.

@ZeeshanTamboli ZeeshanTamboli added dependencies Update of dependencies core Infrastructure work going on behind the scenes labels May 22, 2024
@mui-bot
Copy link

mui-bot commented May 22, 2024

Netlify deploy preview

https://deploy-preview-42335--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 76a1dbb

@ZeeshanTamboli ZeeshanTamboli changed the title [core] Remove WyW-in-JS from Renovate updates [core] Remove WyW-in-JS from Renovate config May 22, 2024
@ZeeshanTamboli ZeeshanTamboli requested a review from a team May 22, 2024 13:10
Copy link
Member

@Janpot Janpot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since it's a transitive dependency, I don't believe renovate would be updating it outside of the lockfile maintenance cycle. So it makes sense to me to remove the grouping. Leaving it to @brijeshb42 for approval.

Copy link
Contributor

@brijeshb42 brijeshb42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not needed here now. It'll be part of Pigment CSS repo. Thanks for removing.

@ZeeshanTamboli ZeeshanTamboli merged commit e7c4a4f into mui:next May 23, 2024
21 checks passed
@ZeeshanTamboli ZeeshanTamboli deleted the remove-wyw-in-js-from-renovate branch May 23, 2024 05:32
@oliviertassinari
Copy link
Member

oliviertassinari commented Jun 1, 2024

Cool, I see it's already in Pigment CSS's repository: https://github.com/mui/pigment-css/blame/f0141110dcdcd0005c2a37b4d064c8467a693ab9/renovate.json#L30 👍

Issue open: mui/pigment-css#119.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes dependencies Update of dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants