Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs][material-ui] Add minor modifications to the Vertical stepper demo #42342

Merged

Conversation

mihilt
Copy link
Contributor

@mihilt mihilt commented May 22, 2024

Description

There is an example code in the 'Vertical stepper' section of the 'Stepper' menu within the documentation.

And I thought it would be better to fix some minor things.

  1. Replaced the static condition index === 2 with a dynamic condition index === steps.length - 1 since people can just copy the example code to their project and edit or add new steps to make their component.
  2. Deleted the div tag as it seemed unnecessary.

@mui-bot
Copy link

mui-bot commented May 22, 2024

Netlify deploy preview

https://deploy-preview-42342--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 8e91440

@danilo-leal danilo-leal changed the title [docs] Minor modifications to the 'Vertical stepper' example code [material-ui][docs] Add minor modifications to the Vertical stepper demo May 22, 2024
@danilo-leal danilo-leal added docs Improvements or additions to the documentation component: stepper This is the name of the generic UI component, not the React module! package: material-ui Specific to @mui/material labels May 22, 2024
Copy link
Contributor

@danilo-leal danilo-leal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet! Thanks for contributing & congrats on the first PR! 🎉

@danilo-leal danilo-leal merged commit 4771db0 into mui:next May 22, 2024
21 of 22 checks passed
@mihilt mihilt deleted the fix/vertical-linear-stepper-code-examples branch May 22, 2024 22:05
@ZeeshanTamboli ZeeshanTamboli changed the title [material-ui][docs] Add minor modifications to the Vertical stepper demo [docs][material-ui] Add minor modifications to the Vertical stepper demo May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: stepper This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation package: material-ui Specific to @mui/material
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants