Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[system][useMediaQuery] Remove deprecated types #42560

Merged

Conversation

aarongarciah
Copy link
Member

@aarongarciah aarongarciah commented Jun 7, 2024

The types being removed were deprecated 3 years ago: #28413. It's a good opportunity to get rid of them for v6.

@mui-bot
Copy link

mui-bot commented Jun 7, 2024

Netlify deploy preview

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 1a379e7

@aarongarciah aarongarciah marked this pull request as ready for review June 7, 2024 10:37
@aarongarciah
Copy link
Member Author

aarongarciah commented Jun 7, 2024

@DiegoAndai the types were not documented, and its deprecation in the past wasn't documented either. Let me know how these types removal are handled in terms of documentation (if any). Technically, this is a breaking change.

@DiegoAndai
Copy link
Member

@aarongarciah, thanks for working on this 🙌🏼

Let me know how these types removal are handled in terms of documentation (if any).

Let's add a small section mentioning the breaking change to the migration guide anyway.

@aarongarciah
Copy link
Member Author

aarongarciah commented Jun 13, 2024

@DiegoAndai added an entry in the migration guide f7c1b6d

@aarongarciah aarongarciah force-pushed the remove-use-media-query-deprecated-types branch from 9b59e54 to f7c1b6d Compare June 13, 2024 13:08
@DiegoAndai
Copy link
Member

@aarongarciah aarongarciah force-pushed the remove-use-media-query-deprecated-types branch from f7c1b6d to 7553900 Compare June 14, 2024 16:18
@aarongarciah aarongarciah force-pushed the remove-use-media-query-deprecated-types branch from 7553900 to 1a379e7 Compare June 14, 2024 16:19
@aarongarciah
Copy link
Member Author

@DiegoAndai done! My bad. I was used to the other page.

Copy link
Member

@DiegoAndai DiegoAndai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@aarongarciah aarongarciah enabled auto-merge (squash) June 14, 2024 16:21
@aarongarciah aarongarciah merged commit 4c46022 into mui:next Jun 14, 2024
22 checks passed
@aarongarciah aarongarciah deleted the remove-use-media-query-deprecated-types branch June 14, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants