-
-
Notifications
You must be signed in to change notification settings - Fork 31.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[system][useMediaQuery] Remove deprecated types #42560
[system][useMediaQuery] Remove deprecated types #42560
Conversation
Netlify deploy previewBundle size report |
@DiegoAndai the types were not documented, and its deprecation in the past wasn't documented either. Let me know how these types removal are handled in terms of documentation (if any). Technically, this is a breaking change. |
@aarongarciah, thanks for working on this 🙌🏼
Let's add a small section mentioning the breaking change to the migration guide anyway. |
@DiegoAndai added an entry in the migration guide f7c1b6d |
9b59e54
to
f7c1b6d
Compare
@aarongarciah may I ask you to move them to: https://github.com/mui/material-ui/blob/next/docs/data/material/migration/migration-v5/migration-v5.md#breaking-changes |
f7c1b6d
to
7553900
Compare
7553900
to
1a379e7
Compare
@DiegoAndai done! My bad. I was used to the other page. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
The types being removed were deprecated 3 years ago: #28413. It's a good opportunity to get rid of them for v6.