Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[material] Remove dependency to @mui/base #42907

Merged
merged 25 commits into from
Jul 12, 2024
Merged

[material] Remove dependency to @mui/base #42907

merged 25 commits into from
Jul 12, 2024

Conversation

mnajdova
Copy link
Member

@mnajdova mnajdova added the core Infrastructure work going on behind the scenes label Jul 11, 2024
@mui-bot
Copy link

mui-bot commented Jul 11, 2024 •
edited
Loading

Netlify deploy preview

https://deploy-preview-42907--material-ui.netlify.app/

@material-ui/utils: parsed: +152.12% , gzip: +70.16%
@material-ui/lab: parsed: +4.00% , gzip: +4.80%
@mui/joy: parsed: +0.20% , gzip: +0.24%
@mui/joy/Tooltip: parsed: +1.00% , gzip: +0.87%
@mui/joy/Autocomplete: parsed: +0.59% , gzip: +0.55%
@mui/joy/Select: parsed: +0.77% , gzip: +0.61%
@material-ui/unstyled: parsed: +0.65% , gzip: +0.09%
SpeedDialAction: parsed: -0.18% 😍, gzip: -0.31% 😍
@material-ui/core: parsed: -0.02% 😍, gzip: -0.08% 😍

Bundle size report

Details of bundle changes (Toolpad)
Details of bundle changes

Generated by 🚫 dangerJS against cc5aea6

@mnajdova mnajdova marked this pull request as ready for review July 11, 2024 12:01
@DiegoAndai DiegoAndai mentioned this pull request Jul 11, 2024
Merged
@aarongarciah
Copy link
Member

@mnajdova today I merged #37301, which contains changes in mui-base. Can you update this PR to include them?

@mnajdova
Copy link
Member Author

@mnajdova today I merged #37301, which contains changes in mui-base. Can you update this PR to include them?

Thanks for the heads up! I will update it tomorrow and have this ready for review :)

@DiegoAndai DiegoAndai mentioned this pull request Jul 11, 2024
Merged
@mnajdova mnajdova added the needs cherry-pick The PR should be cherry-picked to master after merge label Jul 12, 2024
@mnajdova mnajdova requested review from aarongarciah and removed request for michaldudak July 12, 2024 07:26
aarongarciah
aarongarciah approved these changes Jul 12, 2024
View reviewed changes
Copy link
Member

@aarongarciah aarongarciah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

docs/pages/material-ui/api/popper.json Show resolved Hide resolved
mnajdova
mnajdova commented Jul 12, 2024
View reviewed changes
packages/api-docs-builder-core/baseUi/projectSettings.ts
@@ -27,6 +27,9 @@ export const projectSettings: ProjectSettings = {
getHookInfo: getBaseUiHookInfo,
translationLanguages: LANGUAGES,
skipComponent: () => false,
skipHook: (filename) => {
return filename.match(/(useSlotProps)/) !== null;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This hook was anyway not documented, so I've added this option to skip, otherwise the docgen generation failed. It's an optional prop it won't break other ts projects.

@mnajdova
Copy link
Member Author

mnajdova commented Jul 12, 2024 •
edited
Loading

@aarongarciah this is ready for final review. Changes after the approval:

  • moved the utils used in MUI X to @mui/utils to avoid having to add @mui/material as a dependency to some packages that are Material UI agnostic (charts for example)
  • fixed the docs generation script, as Base UI is not just re-exporting some hooks from @mui/utils (useSlotProps)

aarongarciah
aarongarciah approved these changes Jul 12, 2024
View reviewed changes
Copy link
Member

@aarongarciah aarongarciah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏎️ 🚀

@mnajdova
Copy link
Member Author

Thanks for the review @aarongarciah. Next steps:

  • cherry-pick on master
  • create PR on MUI X with the updates
  • after we ensure everything works, mark the @mui/base package as private and stop releasing it

I will move with the next steps.

@mnajdova mnajdova merged commit 3bbff37 into mui:next Jul 12, 2024
23 checks passed
github-actions bot pushed a commit that referenced this pull request Jul 12, 2024
@mnajdova @web-flow
[material] Remove dependency to @mui/base (#42907)
5cb5b4c
@github-actions github-actions bot mentioned this pull request Jul 12, 2024
Merged
oliviertassinari
oliviertassinari reviewed Jul 12, 2024
View reviewed changes
Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the motivation for this change? It seems that the PR description is missing context.

docs/data/material/pagesApi.js
@@ -27,6 +27,7 @@ module.exports = [
{ pathname: '/material-ui/api/checkbox' },
{ pathname: '/material-ui/api/chip' },
{ pathname: '/material-ui/api/circular-progress' },
{ pathname: '/material-ui/api/click-away-listener' },
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm confused about this. Would it mean we will have:

SCR-20240713-bcxd

docs/data/material/pagesApi.js
@@ -125,6 +128,7 @@ module.exports = [
{ pathname: '/material-ui/api/tab-panel' },
{ pathname: '/material-ui/api/tabs' },
{ pathname: '/material-ui/api/tab-scroll-button' },
{ pathname: '/material-ui/api/textarea-autosize' },
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same idea as above with https://stackoverflow.com/questions/454202/creating-a-textarea-with-auto-resize

SCR-20240713-bdjc

@ZeeshanTamboli ZeeshanTamboli mentioned this pull request Jul 14, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari left review comments

@aarongarciah aarongarciah aarongarciah approved these changes

Assignees
No one assigned
Labels
core Infrastructure work going on behind the scenes needs cherry-pick The PR should be cherry-picked to master after merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mnajdova @mui-bot @aarongarciah @oliviertassinari