-
-
Notifications
You must be signed in to change notification settings - Fork 32k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[material-ui][Accordion] Render a heading wrapping AccordionSummary
button per W3C Accordion Pattern standards
#42914
[material-ui][Accordion] Render a heading wrapping AccordionSummary
button per W3C Accordion Pattern standards
#42914
Conversation
Netlify deploy preview
Bundle size reportDetails of bundle changes (Toolpad) |
AccordionSummary
as a heading wrapping a button per W3C Accordion Pattern standardsAccordionSummary
button per W3C Accordion Pattern standards
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this @ZeeshanTamboli, sorry for the late reply.
This looks like a good addition 👍🏼
This might be considered a breaking change as it can break customizations relying on dom structure / specificity. What do you think @aarongarciah?
@DiegoAndai yes, sadly, as of today, changes to the DOM structure of a component should be considered a breaking change. |
pnpm-lock.yaml
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had to run pnpm dedupe
after merging with the latest next
branch.
Since we consider this a breaking change, we need to add an entry in the v6 upgrade guide. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I'll leave the final approval to @DiegoAndai
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ZeeshanTamboli
Fixes #42891
Following the W3C Accordion Pattern, screen reader now announces correctly as:
Previously, it announced as:
Docs previews:
Breaking change: https://deploy-preview-42914--material-ui.netlify.app/material-ui/migration/migrating-to-v6/#accordion
IMO, this change can be cherry-picked to v5 as it is not a breaking change.