Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dialog]correct behavior of esc-click for nested dialogs #4330

Closed
wants to merge 1 commit into from
Closed

[Dialog]correct behavior of esc-click for nested dialogs #4330

wants to merge 1 commit into from

Conversation

zhaoyao91
Copy link

@zhaoyao91 zhaoyao91 commented May 24, 2016 •
edited
Loading

  • PR has tests / docs demo, and is linted.
  • Commit and PR titles begin with [ComponentName], and are in imperative form: "[Component] Fix leaky abstraction".
  • Description explains the issue / use-case resolved, and auto-closes the related issue(s) (http://tr.im/vFqem).

in the old version, if you open nested dialogs, when you click esc, the bottom one will close first, thus causing all inner dialog removed.
this pr fix this by only closing the top dialog on esc clicked.

correct behavior of esc-click for nested dialogs
284da68 
in the old version, if you open nested dialogs, when you click esc, the bottom one will close first, thus causing all inner dialog **removed**.
this pr fix this by only closing the top dialog on esc clicked.
@muibot muibot added PR: Needs Review PR: needs revision The pull request can't be merged. More details is available on the code review or fails in the CI and removed PR: Needs Review labels May 24, 2016
@zhaoyao91 zhaoyao91 changed the title correct behavior of esc-click for nested dialogs [Dialog]correct behavior of esc-click for nested dialogs May 24, 2016
@oliviertassinari
Copy link
Member

oliviertassinari commented Nov 21, 2016 •
edited
Loading

@zhaoyao91 Thanks for this PR, However it has been quite some inactive.
I'm closing it.

Notice that this issue has been solved on the next branch.
We would still accept PR to solve it on the master branch (with some test) but I don't think it worth the effort.
nested

@oliviertassinari oliviertassinari added the component: dialog This is the name of the generic UI component, not the React module! label Nov 21, 2016
@robgev
Copy link

robgev commented Jun 30, 2017

I have material-ui in production app and this is one of the bugs I have. Is it possible to merge this PR to master?

@hzhz hzhz mentioned this pull request Nov 30, 2023
Open
@maniator maniator mentioned this pull request Feb 11, 2024
Open
@hzhz hzhz mentioned this pull request Feb 12, 2024
Open
@akashmitra akashmitra mentioned this pull request Feb 12, 2024
Open
@zhaleTaheri zhaleTaheri mentioned this pull request Feb 12, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
component: dialog This is the name of the generic UI component, not the React module! PR: needs revision The pull request can't be merged. More details is available on the code review or fails in the CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@zhaoyao91 @oliviertassinari @robgev @muibot