Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DropDownMenu] Accept selectedMenuItemStyle prop #5091

Closed
wants to merge 1 commit into from
Closed

[DropDownMenu] Accept selectedMenuItemStyle prop #5091

wants to merge 1 commit into from

Conversation

bricka
Copy link

@bricka bricka commented Aug 29, 2016

  • PR has tests / docs demo, and is linted.
  • Commit and PR titles begin with [ComponentName], and are in imperative form: "[Component] Fix leaky abstraction".
  • Description explains the issue / use-case resolved, and auto-closes the related issue(s) (http://tr.im/vFqem).

This prop allows the selected menu item to be styled. We are achieving
this by passing it through to the underlying Menu component.

This prop allows the selected menu item to be styled.  We are achieving
this by passing it through to the underlying Menu component.
@DoubleU23
Copy link

DoubleU23 commented Oct 13, 2016

? you pass the style object but don't handle/assign it. ?
but thanks for the test.spec

i think PR #5389 does the job

@oliviertassinari
Copy link
Member

oliviertassinari commented Nov 26, 2016

I'm closing this PR as have been quite inactive for a long time and because #5389 is promising.
Thanks for your time!

@zannager zannager added the component: menu This is the name of the generic UI component, not the React module! label Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: menu This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants