Menu calculate new height on _renderVisibility #544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pettomartino
changed the title
|
@pettom I'm sorry I didn't get to merge this before 0.8. Would you like to resubmit the PR? |
|
@hai-cea no problem =) |
pettomartino
force-pushed
the
fix_menu_height
branch
from
533bb04
to
c87605a
Compare
|
@hai-cea Sorry for my confused pull request. I have updated again and I think it cleaner now. |
hai-cea
added a commit
that referenced
this pull request
Jun 3, 2015
Menu calculate new height on _renderVisibility
|
Thanks @pettom ! |
zannager
added
the
component: menu
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I load "menuItens" asynchronously new itens can be added after "componentDidMount" and call "_renderVisibility" again.
I do a hotfix to calculate new height on render visibility.
Thank you.