Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Fix origin documentation #5676

Merged
merged 1 commit into from Nov 28, 2016
Merged

[docs] Fix origin documentation #5676

merged 1 commit into from Nov 28, 2016

Conversation

roman-holovin
Copy link

  • PR has tests / docs demo, and is linted.
  • Commit and PR titles begin with [ComponentName], and are in imperative form: "[Component] Fix leaky abstraction".
  • Description explains the issue / use-case resolved, and auto-closes the related issue(s) (http://tr.im/vFqem).

middle and center values for origin are mixed up. Change in code would be more intuitive (same as vertical-align in CSS), but it will introduce a breaking change.

So I've changed documentation accordingly to the current version of the code.
Fixes #2550

@oliviertassinari oliviertassinari added docs Improvements or additions to the documentation and removed PR: Needs Review labels Nov 28, 2016
@oliviertassinari
Copy link
Member

@Dantix Wow, that's quite an old issue. Thanks for solving it.

@oliviertassinari oliviertassinari merged commit d6c29eb into mui:master Nov 28, 2016
@oliviertassinari oliviertassinari added component: icon button This is the name of the generic UI component, not the React module! component: Popover The React component. labels Nov 28, 2016
@roman-holovin roman-holovin deleted the fix-origin-docs branch November 29, 2016 09:09
@oliviertassinari oliviertassinari changed the title [Docs] Fix origin documentation [docs] Fix origin documentation Dec 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: icon button This is the name of the generic UI component, not the React module! component: Popover The React component. docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants