[Stepper] Allow custom step connector #5741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| import FontIcon from 'src/FontIcon'; | ||
| import getMuiTheme from 'src/styles/getMuiTheme'; | ||
|
|
||
| describe('<Stepper />', () => { |
There was a problem hiding this comment.
We already have a test under src/Stepper/Stepper.spec.js. That would be better to move those tests their.
| </Stepper> | ||
| ); | ||
|
|
||
| assert.equal(wrapper.find(FontIcon).length, 1, 'should contain a <FontIcon /> child'); |
There was a problem hiding this comment.
Use assert.strictEqual( for the strict equality check (===).
| case 0: | ||
| return ( | ||
| <p> | ||
| For each ad campaign that you create, you can control how much you're willing to |
There was a problem hiding this comment.
That ugly GitHub code highlighting can be fixed using a string element: {"For each ad..."}.
oliviertassinari
added
component: stepper
oliviertassinari
approved these changes
Dec 10, 2016
oliviertassinari
added
PR: Review Accepted
and removed
PR: Needs Review
PR: needs revision
|
Thanks. |
oliviertassinari
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows the use of a custom step connector. See #5740.