Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Slider] Add onChange callback signatures to docs #5760

Merged
merged 3 commits into from Dec 13, 2016

Conversation

miclaus
Copy link

@miclaus miclaus commented Dec 11, 2016

  • PR has tests / docs demo, and is linted.
  • Commit and PR titles begin with [ComponentName], and are in imperative form: "[Component] Fix leaky abstraction".
  • Description explains the issue / use-case resolved, and auto-closes the related issue(s) (http://tr.im/vFqem).

Little commit – something I would have needed.

@mbrookes
Copy link
Member

Thanks for adding this. 👍 Would you mind adding the other calbacks in Slider so we can close that one out altogether? 🎉

@oliviertassinari oliviertassinari added the docs Improvements or additions to the documentation label Dec 11, 2016
@miclaus
Copy link
Author

miclaus commented Dec 11, 2016

I added onDragStart and onDragStop callback events docs.

The other on-* events we're marked with /** @ignore */

@oliviertassinari oliviertassinari added PR: Review Accepted component: slider This is the name of the generic UI component, not the React module! and removed PR: Needs Review labels Dec 12, 2016
@oliviertassinari oliviertassinari merged commit 36c13a1 into mui:master Dec 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: slider This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants