Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Node is written mostly in C++, not in C #5776

Merged
merged 1 commit into from Dec 13, 2016
Merged

[docs] Node is written mostly in C++, not in C #5776

merged 1 commit into from Dec 13, 2016

Conversation

Haroenv
Copy link

@Haroenv Haroenv commented Dec 13, 2016 •
edited by oliviertassinari

  • PR has tests / docs demo, and is linted.
  • Commit and PR titles begin with [ComponentName], and are in imperative form: "[Component] Fix leaky abstraction".
  • Description explains the issue / use-case resolved, and auto-closes the related issue(s) (http://tr.im/vFqem).

Well actually the majority of the code in nodejs/node is in JavaScript, but I guess that doesn't really count

@Haroenv
Node is written mostly in C++, not in C
aea6344 
Well actually the majority of the code in nodejs/node is in JavaScript, but I guess that doesn't really count
@Haroenv Haroenv changed the title Node is written mostly in C++, not in C [docs] Node is written mostly in C++, not in C Dec 13, 2016
@oliviertassinari
Copy link
Member

I trust you on that point. Thanks.

@oliviertassinari oliviertassinari merged commit f32152b into mui:master Dec 13, 2016
@oliviertassinari oliviertassinari added docs Improvements or additions to the documentation PR: Review Accepted and removed PR: Needs Review labels Dec 13, 2016
@Haroenv
Copy link
Author

Haroenv commented Dec 13, 2016

I checked the repo to be sure 👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Haroenv @oliviertassinari @muibot