[TimeDisplay] Inherit text color from theme #5816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
requested changes
Dec 23, 2016
| @@ -70,7 +70,7 @@ class TimeDisplay extends Component { | |||
| borderTopLeftRadius: 2, | |||
| borderTopRightRadius: 2, | |||
| backgroundColor: timePicker.headerColor, | |||
| color: 'white', | |||
| color: timePicker.textColor, | |||
There was a problem hiding this comment.
That's a breaking change. We can't merge like that.
timePicker.textColor = palette.accent3ColorI think that we should change that line with palette.textColor
https://github.com/callemall/material-ui/blob/master/src/styles/getMuiTheme.js#L296
There was a problem hiding this comment.
Thanks @oliviertassinari! That makes a lot of sense. I'll update the PR accordingly.
oliviertassinari
added
PR: needs revision
| @@ -293,7 +293,7 @@ export default function getMuiTheme(muiTheme, ...more) { | |||
| }, | |||
| timePicker: { | |||
| color: palette.alternateTextColor, | |||
| textColor: palette.accent3Color, | |||
| textColor: palette.textColor, | |||
There was a problem hiding this comment.
My bad, I would rather be using alternateTextColor as in the datePicker.
|
Hi @oliviertassinari, thanks for your prompt feedback! Let me know what I can do to move this forward. |
oliviertassinari
approved these changes
Dec 24, 2016
oliviertassinari
added
PR: Review Accepted
and removed
PR: Needs Review
PR: needs revision
oliviertassinari
added
the
component: time picker
oliviertassinari
changed the title
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TimeDisplay component has text color fixed to 'white' instead of inheriting it from the theme. I looked at DatePicker component to see how it works, I found out that, unlike TimePicker, it's using datePicket.textColor from theme to set text color. This pull request brings TimePicker on a par with DatePicker.