Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IconMenu] Fix React warning #5843

Merged
merged 1 commit into from Dec 28, 2016
Merged

[IconMenu] Fix React warning #5843

merged 1 commit into from Dec 28, 2016

Conversation

olee
Copy link
Contributor

@olee olee commented Dec 28, 2016

Changed IconMenu to conditionally add button iconStyle

Resolves #4857
References #5496

  • PR has tests / docs demo, and is linted.
  • Commit and PR titles begin with [ComponentName], and are in imperative form: "[Component] Fix leaky abstraction".
  • Description explains the issue / use-case resolved, and auto-closes the related issue(s) (http://tr.im/vFqem).

Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right. Thanks 👍 !

@olee
Copy link
Contributor Author

olee commented Jan 3, 2017

When can I expect a release with this fix or is there a way to install latest (master) from npm?
npm i material-ui@next only installs some 0.16.0-rc version.

@oliviertassinari
Copy link
Member

@olee We release batches every two / three weeks. If you need it asap on your project. Might be best to have a fork until it's released.

@mbrookes
Copy link
Member

mbrookes commented Jan 3, 2017

@olee try:

"dependencies" : {
  "material-ui": "callemall/material-ui",
}

in your package.json, with optional #commit-ish (sha etc.)

You can also manually npm install from a git URL.

@oliviertassinari oliviertassinari changed the title [IconMenu] Changed IconMenu to conditionally add button iconStyle [IconMenu] Fix React warning Jan 15, 2017
@zannager zannager added component: Icon The React component. component: menu This is the name of the generic UI component, not the React module! labels Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: Icon The React component. component: menu This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IconMenu with FlatButton unknown props warning
5 participants