Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Table] Add an integration tests #5845

Merged
merged 1 commit into from Dec 28, 2016
Merged

[Table] Add an integration tests #5845

merged 1 commit into from Dec 28, 2016

Conversation

oliviertassinari
Copy link
Member

  • PR has tests / docs demo, and is linted.
  • Commit and PR titles begin with [ComponentName], and are in imperative form: "[Component] Fix leaky abstraction".
  • Description explains the issue / use-case resolved, and auto-closes the related issue(s) (http://tr.im/vFqem).

Add a test following #5829 fix.

@oliviertassinari oliviertassinari added component: table This is the name of the generic UI component, not the React module! test and removed PR: Needs Review labels Dec 28, 2016
@muibot muibot added the PR: needs revision The pull request can't be merged. More details is available on the code review or fails in the CI label Dec 28, 2016
@oliviertassinari oliviertassinari removed PR: Needs Review PR: needs revision The pull request can't be merged. More details is available on the code review or fails in the CI labels Dec 28, 2016
@oliviertassinari
Copy link
Member Author

Coverage increased (+2.8%)

Not sure it worth 3% but that's good to take.

@oliviertassinari oliviertassinari merged commit f6e66ac into mui:master Dec 28, 2016
@oliviertassinari oliviertassinari deleted the table-add-integration-test branch December 28, 2016 20:03
@oliviertassinari oliviertassinari changed the title [Table] Add an integration test [Table] Add an integration tests Jan 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
component: table This is the name of the generic UI component, not the React module! test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@oliviertassinari @muibot