Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Menu] Add onFocusIndexChange property #5851

Merged

Commits on Dec 29, 2016

  1. [Menu] Add onFocusIndexChange property

    Add a callback property that is called whenever the MenuItem focus is changed.
    
    Sometimes it will be called when the focus isn't changed.  For example:
    * If top menu item is keyboard focused (call mui#1) and then the up arrow is pressed (call mui#2).
    * If some menu item is keyboard focused (call mui#1) and then that same menu item is clicked (call mui#2).
    gabrieldeal committed Dec 29, 2016
    Configuration menu
    Copy the full SHA
    69d07ab View commit details
    Browse the repository at this point in the history
  2. [Menu] Fix spec that was causing Node.js to hang

    Unmounting the Menu component in order to cancel the FocusRipple.pulsate() timer.  Before returning, this timer callback always starts a new setTimeout() for itself.  This outstanding timer stopped Node.js from exiting.
    gabrieldeal committed Dec 29, 2016
    Configuration menu
    Copy the full SHA
    518ff68 View commit details
    Browse the repository at this point in the history

Commits on Jan 3, 2017

  1. [Menu] Change setFocusIndex argument order

    Put the `event` argument at the front to be consistent with other functions.
    gabrieldeal committed Jan 3, 2017
    Configuration menu
    Copy the full SHA
    8d63daa View commit details
    Browse the repository at this point in the history
  2. [Menu] Add spec for hotkeys

    Add a spec for selecting a MenuItem via hotkeys. The new spec uncovered two pre-existing bugs.
    gabrieldeal committed Jan 3, 2017
    Configuration menu
    Copy the full SHA
    b627c27 View commit details
    Browse the repository at this point in the history