[EnhancedButton] remove unnecessary hack, improving overall performance #5868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muibot
added
PR: Needs Review
PR: needs revision
oliviertassinari
added
PR: Review Accepted
and removed
PR: Needs Review
PR: needs revision
|
@jampy Thanks for this PR! I agree with your points. Creating an additional layer is a tradeoff that should be well motivated. In our case, that wasn't providing any frame rate improvement, we were just paying the memory cost of them. |
3 tasks
oliviertassinari
changed the title
| * See: http://stackoverflow.com/questions/17298739/ | ||
| * css-overflow-hidden-not-working-in-chrome-when-parent-has-border-radius-and-chil | ||
| */ | ||
| transform: disableTouchRipple && disableFocusRipple ? null : 'translate(0, 0)', |
There was a problem hiding this comment.
deleting this hack broke our design
There was a problem hiding this comment.
Could you provide more detail?
There was a problem hiding this comment.
@oliviertassinari we use FloatingActionButton with FontIcon that have rotate on hover, (in this case border radius not working)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #5867
This PR simply removes an older workaround that added a
transform: translate(0,0)to all buttons. This forced the browser to create a GPU context for each button, preventing optimization of parent elements in some cases.Since EnhancedButton is used in lots of other components, this PR perhaps improves overall performance in complex apps (but help of others is needed to verify this).
Fopr more information please see: