Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FloatingActionButton] Fix thin white border #5881

Merged
merged 2 commits into from Jan 6, 2017

Conversation

ludoviccyril
Copy link

@ludoviccyril ludoviccyril commented Jan 6, 2017

  • PR has tests / docs demo, and is linted.
  • Commit and PR titles begin with [ComponentName], and are in imperative form: "[Component] Fix leaky abstraction".
  • Description explains the issue / use-case resolved, and auto-closes the related issue(s) (http://tr.im/vFqem).

Hello there.

I've noticed that there is a thin white border around FloatingActionButton's. It's particularly visible when the FloatingActionButton and the underlying element use dark colors, and it really looks bad:

screen shot 2017-01-06 at 1 29 51 am

The expected look and feel is:

screen shot 2017-01-06 at 1 29 57 am

Upon taking a look at the source code, I realized this happens because FloatingActionButton's contain a Paper element, whose default color is white. I suggest setting the background-color of that Paper element to transparent to solve this issue.

Here's the WebpackBin for this issue.

@muibot muibot added PR: Needs Review PR: needs revision The pull request can't be merged. More details is available on the code review or fails in the CI and removed PR: Needs Review labels Jan 6, 2017
@oliviertassinari oliviertassinari added bug 🐛 Something doesn't work PR: Review Accepted and removed PR: Needs Review PR: needs revision The pull request can't be merged. More details is available on the code review or fails in the CI labels Jan 6, 2017
@oliviertassinari
Copy link
Member

I confirm the issue. That looks good to me. Thanks.

@oliviertassinari oliviertassinari merged commit 75ad6dd into mui:master Jan 6, 2017
@oliviertassinari oliviertassinari changed the title [FloatingActionButton] Get Rid of Thin White Border [FloatingActionButton] Fix thin white border Jan 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants