Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Fix spelling mistake in PropTypeDescription.js #5883

Merged
merged 1 commit into from Jan 6, 2017

Conversation

Jbarget
Copy link

@Jbarget Jbarget commented Jan 6, 2017

Fixes #5882

  • PR has tests / docs demo, and is linted.
  • Commit and PR titles begin with [ComponentName], and are in imperative form: "[Component] Fix leaky abstraction".
  • Description explains the issue / use-case resolved, and auto-closes the related issue(s) (http://tr.im/vFqem).

@muibot muibot added PR: Needs Review PR: needs revision The pull request can't be merged. More details is available on the code review or fails in the CI and removed PR: Needs Review labels Jan 6, 2017
@mbrookes mbrookes changed the title Docs: Spelling mistake in docs/src/app/components/PropTypeDescription.js [Docs] Spelling mistake in docs/src/app/components/PropTypeDescription.js Jan 6, 2017
@mbrookes mbrookes changed the title [Docs] Spelling mistake in docs/src/app/components/PropTypeDescription.js [Docs] Fix spelling mistake in docs/src/app/components/PropTypeDescription.js Jan 6, 2017
@mbrookes
Copy link
Member

mbrookes commented Jan 6, 2017

Thanks for the PR. I've made some changes to the title and description so that the ticked-boxes are actually valid (just ticking them doesn't make it so 😄 )

Not sure what's going on with the tests though.

@Jbarget
Copy link
Author

Jbarget commented Jan 6, 2017

haha @mbrookes, apologies!
failing CI seems to be because of Cannot find module 'react/lib/EventPluginHub' when it tries to run npm test

@oliviertassinari oliviertassinari added docs Improvements or additions to the documentation PR: Review Accepted and removed PR: needs revision The pull request can't be merged. More details is available on the code review or fails in the CI labels Jan 6, 2017
@muibot muibot added the PR: needs revision The pull request can't be merged. More details is available on the code review or fails in the CI label Jan 6, 2017
@oliviertassinari oliviertassinari removed the PR: needs revision The pull request can't be merged. More details is available on the code review or fails in the CI label Jan 6, 2017
@Jbarget
Copy link
Author

Jbarget commented Jan 6, 2017

@oliviertassinari any idea why it might be having issues with running npm test?

@mbrookes
Copy link
Member

mbrookes commented Jan 6, 2017

@Jbarget We don't need tests for a typo anyway, so merging as is.

@mbrookes mbrookes merged commit 5f42b5e into mui:master Jan 6, 2017
@mbrookes
Copy link
Member

mbrookes commented Jan 6, 2017

Actually @oliviertassinari, even with the typo corrected the wording is a bit ambiguous. Would something like:

"Any other properties supplied will be spread to the root element."

be better?

@oliviertassinari
Copy link
Member

@mbrookes That sounds good. We could change that on the next branch 👍 .

@oliviertassinari oliviertassinari changed the title [Docs] Fix spelling mistake in docs/src/app/components/PropTypeDescription.js [docs] Fix spelling mistake in PropTypeDescription.js Jan 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants