[MenuItem] Add an anchorOrigin property for the nested items #6079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muibot
added
PR: needs revision
oliviertassinari
removed
the
PR: needs revision
|
+1 we need this! |
oliviertassinari
added
the
component: menu
oliviertassinari
approved these changes
Feb 15, 2017
oliviertassinari
requested changes
Feb 15, 2017
src/MenuItem/MenuItem.js
Outdated
| @@ -59,6 +59,10 @@ class MenuItem extends Component { | |||
|
|
|||
| static propTypes = { | |||
| /** | |||
| * Override the default anchorOrigin children used. | |||
| */ | |||
| anchorOrigin: PropTypes.object, | |||
There was a problem hiding this comment.
Please use the utils/propTypes.origin helper. You can have a look at the other components to see how it's done.
src/MenuItem/MenuItem.js
Outdated
| @@ -59,6 +59,10 @@ class MenuItem extends Component { | |||
|
|
|||
| static propTypes = { | |||
| /** | |||
| * Override the default anchorOrigin children used. | |||
There was a problem hiding this comment.
We need to improve the wording. We should refer to the nested menu at least.
Here is what we have on the Popover:
/**
* This is the point on the anchor where the popover's
* `targetOrigin` will attach to.
* Options:
* vertical: [top, center, bottom]
* horizontal: [left, middle, right].
*/There was a problem hiding this comment.
Updated wording to:
Location of the anchor for the popover of nested `MenuItem` elements.
oliviertassinari
added
PR: needs revision
[MenuItem] Use util/propTypes origin helper for propType for anchorOrigin propType
oliviertassinari
approved these changes
Feb 16, 2017
oliviertassinari
added
PR: Review Accepted
and removed
PR: Needs Review
PR: needs revision
oliviertassinari
changed the title
|
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gives similar functionality as animation prop to childMenuPopover.