[TextField] Add an inputProps property #6111

oliviertassinari · 2017-02-10T21:18:42Z

PR has tests / docs demo, and is linted.
Commit and PR titles begin with [ComponentName], and are in imperative form: "[Component] Fix leaky abstraction".
Description explains the issue / use-case resolved, and auto-closes the related issue(s) (http://tr.im/vFqem).

mbrookes · 2017-02-10T22:48:21Z

src/TextField/TextField.js

@@ -23,6 +23,7 @@ export default class TextField extends Component {
     * The CSS class name of the root element.
     */
    className: PropTypes.string,
+    disabled: PropTypes.bool,


Please could you add a comment for the API docs? It will be a lot of work to go back and add these later. (Trust me, I did it once! 😆)

mbrookes · 2017-02-10T22:48:24Z

src/TextField/TextField.js

@@ -47,6 +52,14 @@ export default class TextField extends Component {
     * Whether the label should be displayed as required (asterisk).
     */
    required: PropTypes.bool,
+    /**
+     * Input type.


This feels a bit terse. (I know it's an HTML property, and we don't normally explicitly expose or document those, but it may not be immediately obvious what the supported values are.)

oliviertassinari added component: text field This is the name of the generic UI component, not the React module! next labels Feb 10, 2017

muibot added the PR: Needs Review label Feb 10, 2017

mbrookes reviewed Feb 10, 2017

View reviewed changes

[TextField] Add an inputProps property

3923cf7

oliviertassinari merged commit 4f674e7 into mui:next Feb 11, 2017

oliviertassinari deleted the expose-input-element branch February 11, 2017 20:53

mbrookes added PR: Review Accepted and removed PR: Needs Review labels Feb 11, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[TextField] Add an inputProps property #6111

[TextField] Add an inputProps property #6111

oliviertassinari commented Feb 10, 2017

mbrookes Feb 10, 2017

mbrookes Feb 10, 2017

[TextField] Add an inputProps property #6111

[TextField] Add an inputProps property #6111

Conversation

oliviertassinari commented Feb 10, 2017

mbrookes Feb 10, 2017

Choose a reason for hiding this comment

mbrookes Feb 10, 2017

Choose a reason for hiding this comment