Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EnhancedSwitch] Remove dead "toggled" property #6182

Merged
merged 2 commits into from
Feb 20, 2017
Merged

[EnhancedSwitch] Remove dead "toggled" property #6182

merged 2 commits into from
Feb 20, 2017

Conversation

Shahrukh-Zindani
Copy link

  • PR has tests / docs demo, and is linted.
  • Commit and PR titles begin with [ComponentName], and are in imperative form: "[Component] Fix leaky abstraction".
  • Description explains the issue / use-case resolved, and auto-closes the related issue(s) (http://tr.im/vFqem).

oliviertassinari
oliviertassinari requested changes Feb 19, 2017
View reviewed changes
Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The toggled property is a legacy one. Could you remove all references to it in the EnhancedSwitch component?

@oliviertassinari oliviertassinari added PR: needs revision The pull request can't be merged. More details is available on the code review or fails in the CI and removed PR: Needs Review labels Feb 19, 2017
@oliviertassinari oliviertassinari added PR: Review Accepted and removed PR: Needs Review PR: needs revision The pull request can't be merged. More details is available on the code review or fails in the CI labels Feb 19, 2017
@dhoward dhoward mentioned this pull request Feb 20, 2017
Merged
3 tasks
@oliviertassinari oliviertassinari merged commit 547178d into mui:master Feb 20, 2017
@oliviertassinari oliviertassinari changed the title [EnhancedSwitch] Add "toggled" in props validation. [EnhancedSwitch] Remove dead "toggled" property Feb 21, 2017
@zannager zannager added the component: switch This is the name of the generic UI component, not the React module! label Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees
No one assigned
Labels
component: switch This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Shahrukh-Zindani @oliviertassinari @muibot @zannager @shahrukhzindani